Evaluate script conditions eagerly #2056
Open
+58
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
platform
,visible
,notVisible
and thentrue
visible
andnotVisible
take a lot of time to run when they are not satisfied, as there's a default timeout to check the hierarchy for the presence of an elementtrue
in the 2nd position makes a lot of cases run much fasterAs an example, in our flows we had to do stuff like this to workaround this use case
This saves several seconds each time (17s exactly)
Testing
visible
does not even run if there's a falsetrue
beforeIssues fixed
None