[WIP] Detector Comparison Charts #54
Conversation
… Added raw-detections and simple-binning labeling methods. Added similarity-ratio as a comparison method.
|
@locook03 what are you using the package for and are you trying to add new detectors/etc.? I haven't really been maintaining, but if there's interest, I can patch up some of the dev issues. |
|
Hey @adam2392 , I'm working with Patrick Myers to complete the comparison functions and eventually to add a data pipeline and additional detectors. I've patched up some of the dev issues, but I would appreciate it if you reviewed as well! |
Okay I will try to find some time to get the CIs working and running again. I will also have to upgrade the entire package to Python 3.8+ as Python 3.6/3.7 have reached End-of-life. |
|
It would help if you create a GH issue, or put it in the PR description what exactly the problem it is you're trying to solve with this PR. |
| """ | ||
|
|
||
| # If no axis is provided, the current axis will be used, | ||
| if ax == None: |
There was a problem hiding this comment.
I don't know if this works if there is no figure. The way I have always seen this done is:
if ax is None:
fig, ax = plt.subplots(...)
that way you also have control over things like figure size
| ax.plot() | ||
| return ax |
There was a problem hiding this comment.
for consistency with the other plotting functions, I would return both fig, ax and then I would make the fig, ax as optional inputs for plot_hfo_events
| ax.plot() |
There was a problem hiding this comment.
Does this line do anything?
|
Feel free to change and update as is and ping me if I need to look at anything. Otherwise, I'll give you guys free reign to try stuff out :) |
Thanks for contributing. If this is your first time,
make sure to read contributing.md
PR Description
Merge checklist
Maintainer, please confirm the following before merging: