-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] The Great CMake Migration #902
Conversation
b2cbf85
to
2bd4537
Compare
e494f81
to
b5779d8
Compare
On the question of naming authors on top of the file (above the license), what is the appropriate thing to do in this case? I see a lot of the .pro files have many many (many) authors; is the best thing to do to keep the same authorship in the new equivalent CMakeLists.txt file? Or since this is a new completely new file I should only include the names of the people who worked on the new CMakeLists file? |
@gabrielbmotta I think it would be ok to remove all names and just add yours or leave names out of the files completley. Technically it should be enough to have the git history of the files to identify who worked on them? |
At some point I gave it a thought. My 2cents:
I would also get rid of the //====.... rows. And the comment blocks announcing "header files" or "forward declarations"... they all get on the way. But I would understand that it might be just my opinion. |
I can definitely get behind the offloading the license to a single file and only doing a short header, and maybe adding a single text file with the name of all contributors to the project. I do like the organization of having the |
If we do end up changing the headers, I would prefer doing it in a separate PR, if that is ok. |
I think this is looking good. Close to merging state. @LorenzE any comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@gabrielbmotta @juangpc Sry I did not read your comment. Great work! This merge really makes me happy :) Will it give a try when I have time :) |
Currently have all the libraries, examples, and applications building with cmake. Using newer version of eigen that has cmake backend.
To do: