-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Utils library Qt-less refactor (Part 1 of many) #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
great! |
Codecov Report
@@ Coverage Diff @@
## main #881 +/- ##
==========================================
+ Coverage 30.20% 36.28% +6.08%
==========================================
Files 452 195 -257
Lines 39208 11805 -27403
==========================================
- Hits 11841 4284 -7557
+ Misses 27367 7521 -19846
|
The qt installer action for linux is |
juangpc
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes over a majority of the utils library and adds a std lib api (and a std lib backend) to most classes and static functions.
Also:
min c++ version set to c++ 17 for use of filesystem library. Is this ok? this is a 5 year old standard at this point.(reverted, was causing issues with ubuntu 18 and osx 10.15 and lower std lib version. No longer using filesystem lib. )
Because adding more code results in a lower code coverage percentage even though the functions I overloaded were not being tested anyway (I think), I also wrote a test for circular buffer to bump up code coverage.
What is missing: