MAINT: Update BIDS Validator infrastructure #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sappelhoff
commented
Sep 2, 2024
sappelhoff
commented
- accompanies CI: add BIDS schema validator #1302
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
- Coverage 97.61% 97.45% -0.16%
==========================================
Files 40 40
Lines 8685 8776 +91
==========================================
+ Hits 8478 8553 +75
- Misses 207 223 +16 ☔ View full report in Codecov by Sentry. |
sappelhoff
commented
Sep 2, 2024
mne_bids/tests/conftest.py
Outdated
| @@ -21,7 +21,8 @@ | |||
| @pytest.fixture(scope="session") | |||
| def _bids_validate(): | |||
| """Fixture to run BIDS validator.""" | |||
| vadlidator_args = ["--config.error=41"] | |||
| # vadlidator_args = ["--config.error=41"] | |||
There was a problem hiding this comment.
Was this really https://github.com/bids-standard/bids-validator/blob/690a34a5a723b8b436f19d9bc4da3b7a2acfaad4/bids-validator/utils/issues/list.js#L225-L229 ?
41: {
key: 'NIFTI_UNIT',
severity: 'warning',
reason:
"NIfTI file's header field for unit information for x, y, z, and t dimensions empty or too short",
There was a problem hiding this comment.
ok, got it. This was related to:
fixed in:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.