correctly track anonymization date of empty room recordings when written simultaneously with data #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
approved these changes
Jul 12, 2024
agramfort
approved these changes
Jul 12, 2024
Comment on lines
+3154
to
+3163
| erm = dict() | ||
| else: | ||
| bids_path.update(task="task", suffix="eeg", datatype="eeg") | ||
| # make sure anonymization works when also writing empty room file | ||
| erm = dict(empty_room=raw.copy()) | ||
| daysback_min, daysback_max = get_anonymization_daysback(raw) | ||
| anonymize = dict(daysback=daysback_min + 1) | ||
| orig_bids_path = bids_path.copy() | ||
| bids_path = write_raw_bids( | ||
| raw, bids_path, overwrite=True, anonymize=anonymize, verbose=False | ||
| raw, bids_path, overwrite=True, anonymize=anonymize, verbose=False, **erm |
There was a problem hiding this comment.
I think this can be simplified to
if subject == "emptyroom":
...
er_raw=None
else:
...
er_raw = raw.copy()
...
write_raw_bids(..., empty_room=er_raw)or so
There was a problem hiding this comment.
Sure, that's a slight improvement I guess
There was a problem hiding this comment.
I think we can merge this as is though, I think the difference in code here is miniscule. Thanks for the PR and the reviews.
There was a problem hiding this comment.
i don't know, why would you create a dict if you don't need it? just to later unpack the only element it contains 🧐
There was a problem hiding this comment.
@hoechenberger see #1274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1269
PR Description
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: