Added missing debug.log feature mentioned in help.md and added nix flake#42
Open
Nimrodium wants to merge 12 commits intommulet:mainfrom
Open
Added missing debug.log feature mentioned in help.md and added nix flake#42Nimrodium wants to merge 12 commits intommulet:mainfrom
Nimrodium wants to merge 12 commits intommulet:mainfrom
Conversation
…e logging including printing Args
…f atoi err return
… flake since termeverything doesnt support macos
Owner
|
Thanks for the PR, I can review this in about a week from now. |
Owner
|
Pushing it back another week, because this week has been crazy busy for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried running this on NixOS but it couldn't execute the command because it uses
/bin/bashwhich is not present on NixOS,/bin/shis present though as its mandated by posix standards to be there iirc. when i was trying to debug this i tried to use the--debug-logfeature but noticed it was not implemented, so I implemented it, it has the ability to use a file other than "debug.log" but I did not end up making it accessible to the CLI. there is also now a verbose mode, i replaced the instances of printing to Stderr with my logging function but did not touch anything inwayland/I also made term.everything return early if the command fails instead of just hanging and confusing the user as to why its not doing anything.
And finally I also added a nix flake, it doesn't build a static executable since there isn't much point to doing that if you already have nix installed so it just builds a regular executable.
now term.everything can be run just by
nix run github:mmulet/term.everythingassuming the PR is merged.if i implemented anything weirdly that is because this is my first time using Go. (from this, its a nice language but im absolutely flabbergasted that unused variables are errors)