Fix bugs related to Reference.discovered
#323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the object scanner does not scan this field when reference processing is enabled, causing all nodes after the head node of any linked lists of `Reference` instances linked by the `discovered` field to be treat as garbage. We fix this by treating the `discovered` field as a strong field. Another bug is related to the deduplication procedure in `mmtk_enqueue_references`. The code intended to handle adjacent duplicated element, but was wrong. That bug was beingn and the worst it could do is making the last node temporarily point to itself before re-assigned the proper pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the object scanner does not scan this field when reference processing is enabled, causing all nodes after the head node of any linked lists of
Referenceinstances linked by thediscoveredfield to be treat as garbage. We fix this by treating thediscoveredfield as a strong field.Another bug is related to the deduplication procedure in
mmtk_enqueue_references. The code intended to handle adjacent duplicated element, but was wrong. That bug was benign and the worst it could do is making the last node temporarily point to itself before re-assigned the proper pointer.