Refactor CI test scripts #263
Conversation
qinsoon
force-pushed
the
refactor-correctness-ci
branch
2 times, most recently
from
d155bda
to
0f38978
Compare
qinsoon
force-pushed
the
refactor-correctness-ci
branch
3 times, most recently
from
48bcb63
to
be01ed4
Compare
qinsoon
force-pushed
the
refactor-correctness-ci
branch
from
be01ed4
to
0307418
Compare
qinsoon
force-pushed
the
refactor-correctness-ci
branch
from
1c4621c
to
2530d23
Compare
qinsoon
force-pushed
the
refactor-correctness-ci
branch
from
f1195c3
to
f636d6f
Compare
qinsoon
force-pushed
the
refactor-correctness-ci
branch
from
32feee6
to
26957e3
Compare
qinsoon
force-pushed
the
refactor-correctness-ci
branch
from
26957e3
to
b581535
Compare
qinsoon
force-pushed
the
refactor-correctness-ci
branch
2 times, most recently
from
7c9ba96
to
137ab0f
Compare
qinsoon
force-pushed
the
refactor-correctness-ci
branch
from
137ab0f
to
016370e
Compare
.github/scripts/ci-build.sh
Outdated
| F=`ls *_bin-debug.tar.gz` | ||
| mv $F ${F/_bin-debug/_bin} |
There was a problem hiding this comment.
We can use the rename command line utility for this. But also see the other comment on build.yml.
| F=`ls *_bin-debug.tar.gz` | |
| mv $F ${F/_bin-debug/_bin} | |
| rename _bin-debug _bin *_bin-debug.tar.gz |
.github/workflows/build.yml
Outdated
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: linux-x86_64-server-${{ inputs.debug-level }}-bundles-${{ env.BUILD_SUFFIX }} | ||
| path: ./git/openjdk/build/linux-x86_64-normal-server-${{ inputs.debug-level }}/bundles/*_bin.tar.gz |
There was a problem hiding this comment.
This is the only place the _bin.tar.gz file (instead of _bin-debug.tar.gz) is used. If we can use wildcard here, we won't need to change the file name.
There was a problem hiding this comment.
I removed the renaming in ci-build.sh, and added two paths (*_bin.tar.gz and *_bin-debug.tar.gz) here for matching and uploading artifacts. I will see if it works.
.github/workflows/stylecheck.yml
Outdated
| style-check: | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
checkout@v2 is too old. We should bump it to v4. Since this PR is doing refactoring, it is a good chance to do a global search/replacement for GitHub actions like this.
There was a problem hiding this comment.
I changed all the checkout uses to v4.
names in artifact uploading
|
The log shows that the CI successfully uploaded But And the log shows it is still using DaCapo Chopin RC3 instead of the released version. |
We have random failures in the dacapo chopin tests.
Yeah. I don't plan to move to the release version in this PR. |
| DEBUG_LEVEL=${DEBUG_LEVEL:="fastdebug"} | ||
|
|
||
| # Build target. Could be empty, or product-bundles. | ||
| build_target=$1 |
| cd $OPENJDK_PATH | ||
| runbms_dacapo2006_with_heap_multiplier fop $heap_multiplier | ||
| runbms_dacapo2006_with_heap_multiplier luindex $heap_multiplier | ||
| } | ||
|
|
||
| # -- SemiSpace -- | ||
| export MMTK_PLAN=SemiSpace |
There was a problem hiding this comment.
I thought the idea was to move away from using environment variables since OpenJDK has support for passing MMTk options
This PR tries to consolidate the new dacapo chopin tests and the old dacapo 2006 tests to make them consistent. It also exposes tests to mmtk-core using Github workflows rather than shell scripts (WIP, mmtk/mmtk-core#935). It fixes the heap sizes for 2006 tests (mmtk/mmtk-core#424).
Changes in the PR:
ci-test.shstill works (binding tests in the mmtk-core repo is still functioning).WIP:
test-core-extended.ymlandtest-core-minimal.yml(Minimal tests (including some binding tests) and extended tests. mmtk-core#935) needs more work. However, I cannot test them at the moment. Workflow dispatch only works if the workflows exist in the default branch. I need to get them merged first, then start modifying and testing them.