Fix memory leak due to incorrect root scanning #141
+104
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyuzhao
changed the title
|
@qinsoon is it possible to trigger a benchmark github action here? like the ones we did to the mmtk-core PRs? |
Unfortunately we can't. Those are only set up for mmtk-core yet. I can set up performance CI for OpenJDK, as we are doing more development work for OpenJDK and it is probably necessary/worth to set up performance CI. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes memory leaks caused by incorrect root scanning.
Pointers in
CodeCache,StringTableandWeakProcessorare not treated as roots. The processing of these object storage is postponed to the end of tracing. Pointers in these object storages are either removed (if they are dead) or forwarded (if they're moved).Note that some benchmarks still leak, due to the missing of weak-ref processing and class unloading. These are not addressed in this PR and is expected to be fixed in the future (we should already have issues for weak-ref and class unloading).
TODO: do a benchmark