Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atomic and/or for marking and forwarding #863

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wks
Copy link
Collaborator

@wks wks commented Jul 3, 2023

Use atomic and/or operation instead of atomic store for marking and forwarding.

Atomic store is currently implemented with compare-exchange or fetch_update. Atomic and/or operations may be much faster because they are unconditional and do not need a loop.

@wks
Copy link
Collaborator Author

wks commented Jul 3, 2023

I ran lusearch on mole.moma with 2.4x min heap size using several plans. PGO is enabled, and the profile is collected from running all of those plans. VO bit is disabled.

https://squirrel.anu.edu.au/plotty/wks/noproject/#0|mole-2023-07-03-Mon-051852&benchmark^build^invocation^iteration^mmtk_gc&GC^time^time.other^time.stw&|10&iteration^1^4|20&1^invocation|30&1&benchmark^mmtk_gc&build;build1|41&Histogram%20(with%20CI)^build^mmtk_gc&

image

There is slight improvement in STW time for GenImmix, almost no effect for Immix and StickyImmix, but there is slowdown for MarkCompact and serious slow down for SemiSpace. The strange thing is there is slowdown in mutator time for SemiSpace, too.

Not sure what caused this. Maybe unconditionally storing to the metadata using atomic AND/OR caused more cache misses than the conditional cmpxchg which doesn't need to write if the old value is already expected. Maybe PGO is adding uncertainty to the measurement.

Anyway, I'll not prioritise this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant