Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #730.
usize
rather thanisize
. We never allow negative values, and it was a mistake to useisize
.align_alloc
andget_maximum_aligned_size
, update the implementation and add unit tests.get_maximum_aligned_size
also requiresoffset
to work properly.FreeListAllocator
) is updated. As we would need to pass around bothalign
andoffset
, we simply calculatebin
once, and pass it around instead.known_alignment
should beVM::ALLOC_END_ALIGNMENT
rather thanMIN_ALIGNMENT
.