Minor changes to the ProcessRootNode work packet #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no objects are enqueued, we do not blindly create empty `ScanObjects` work packets. During nursery GC, it is likely that many root edges point to mature nodes, and mature objects are not enqueued during nursery GC. We also added eBPF trace points to show how many roots are there in a ProcessRootNodes work packet, and how many objects are actually enqueued.
Also update README.md
|
@qinsoon I opened this PR because when debugging CRuby binding, I found that some |
qinsoon
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
ProcessRootNodetoProcessRootNodesbecause it obviously processes multiple roots.If no objects are enqueued, we do not blindly create empty
ScanObjectswork packets. During nursery GC, it is likely that many root edges point to mature nodes, and mature objects are not enqueued during nursery GC.We also added eBPF trace points to show how many roots are there in a ProcessRootNodes work packet, and how many objects are actually enqueued.