Full amplitude as matrix #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmikhasenko
force-pushed
the
wigner-d-speed-up
branch
from
2da8876
to
9b2911d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28
Closes #27
Speed up (
x60)Working with matrices speeds up the code by a factor of
x40, 🎉Another 20% one gains using @tullion for index loops.
Test
The Intervention let do a finding that test coverage on full model functionality was pure.
New tests with 20 chains of different
kimprove the coverage.Breaking
SymbolicThreeBodyDecays.jlwork due tothat used to be from
two_λsamplitudewith two arguments is used for full_amplitude computation, but also for dalitz-plot point evaluation. The conflict is resolved by specifying the type of sigma for the first call.It's not ideal, since
SymbolicTBDs.jlwon't work again