Skip to content

Commit

Permalink
Merge pull request haskell#10033 from bacchanalia/8963
Browse files Browse the repository at this point in the history
Add comment clarifying disabling check for scripts
  • Loading branch information
mergify[bot] authored May 24, 2024
2 parents d1a6ced + d03137e commit a6b99b8
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Cabal/src/Distribution/PackageDescription/Check/Target.hs
Original file line number Diff line number Diff line change
Expand Up @@ -825,9 +825,10 @@ checkGHCOptions title t opts = do
checkFlags
["-prof"]
(PackageBuildWarning $ OptProf title)
-- Does not apply to scripts.
-- Why do we need this? See #8963.
pid <- asksCM (pnPackageId . ccNames)
-- Scripts add the -o flag in the fake-package.cabal in order to have the
-- executable name match the script name even when there are characters
-- in the script name which are illegal to have as a target name.
unless (pid == fakePackageId) $
checkFlags
["-o"]
Expand Down

0 comments on commit a6b99b8

Please sign in to comment.