Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid non-API calls #1227

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Avoid non-API calls #1227

merged 1 commit into from
Jan 6, 2025

Conversation

shikokuchuo
Copy link
Contributor

@shikokuchuo shikokuchuo commented Jan 3, 2025

Solves the CRAN check NOTEs for PRCODE, PRENV and Rf_findVarInFrame3.

As the fundamental R types are defined as a union at the top of Defn.h, we're able to simply use alternative accessors.

@dfalbel
Copy link
Member

dfalbel commented Jan 3, 2025

Thanks @shikokuchuo !

@dfalbel dfalbel merged commit e93430f into mlverse:main Jan 6, 2025
5 of 7 checks passed
@shikokuchuo shikokuchuo deleted the dev branch January 6, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants