Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ignite #1223

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Feat/ignite #1223

wants to merge 16 commits into from
+3,989 −290

Conversation

sebffischer
Copy link
Collaborator

@sebffischer sebffischer commented Dec 23, 2024 •
edited
Loading

Supersedes #1215

TODOs:

  • The compiler complains about returning the adamw_options custom struct, so maybe we also need to wrap it in a void*
  • Implement the remaining optimizers
  • check that initial values for optimizer options are specified correctly
  • make the test for adamw generic and apply it to all optimizers
  • More tests:
    • parameters are cloned when loaded
    • loading existing state dict is equal to not doing anything (optimized weights are the same)

@sebffischer
Copy link
Collaborator Author

@dfalbel can you tag this with 'lantern' again please?

@dfalbel dfalbel added the lantern Use this label if your PR affects lantern so it's built in the CI label Jan 3, 2025
@dfalbel
Copy link
Member

dfalbel commented Jan 3, 2025

@sebffischer Sorry for the delay! Just tagged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lantern Use this label if your PR affects lantern so it's built in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebffischer @dfalbel