ADD unit test for specified times in create_res_sim #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fqjin
added a commit
to fqjin/fem
that referenced
this pull request
Oct 5, 2022
* Update test_get_t * Fix parenthesis typo Co-authored-by: Felix Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fqjin wrote a unit test to just show equivalent function of the list specification for timesteps vs. the previous default of just passing in an int to represent the total number of timesteps. Right now, it appears that the input specification is not consistent. Can you look at the failing test and see if I'm misinterpreting the way it should work?
Issue #114