-
Couldn't load subscription status.
- Fork 8
feat: select the center of the peaks by scoring peak candidates #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select the center of the peaks by scoring peak candidates #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jobo322 You should add a test case.
|
Also add the DOI of the paper. |
There is not a paper, I found a poster of GSD |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 92.11% 93.96% +1.84%
==========================================
Files 16 24 +8
Lines 571 746 +175
Branches 121 152 +31
==========================================
+ Hits 526 701 +175
Misses 44 44
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jobo322 No testcase were change if I understood well, just new one. So this PR is good for me.
Please fix the testcase. new rule that force us in package.json to exports
{ ".": "./lib/index.js" } like in https://github.com/mljs/signal-processing/blob/main/package.json#L7


No description provided.