Skip to content

Conversation

@jobo322
Copy link
Member

@jobo322 jobo322 commented Sep 12, 2025

No description provided.

@jobo322
Copy link
Member Author

jobo322 commented Sep 12, 2025

checking the result of this directly on nmrium to visualize. gsd without a smoothing of the data with the current refactoring

old version new version
Image image

@jobo322 jobo322 requested a review from lpatiny September 12, 2025 16:15
Copy link
Member

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jobo322 You should add a test case.

@lpatiny
Copy link
Member

lpatiny commented Sep 15, 2025

Also add the DOI of the paper.

@jobo322
Copy link
Member Author

jobo322 commented Sep 16, 2025

Also add the DOI of the paper.

There is not a paper, I found a poster of GSD
http://www.ebyte.it/stan/Poster_GSD.html

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 98.82353% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.96%. Comparing base (6e3584d) to head (c327201).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/algorithms/getMinMaxIntervals.ts 92.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   92.11%   93.96%   +1.84%     
==========================================
  Files          16       24       +8     
  Lines         571      746     +175     
  Branches      121      152      +31     
==========================================
+ Hits          526      701     +175     
  Misses         44       44              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jobo322 jobo322 marked this pull request as ready for review September 20, 2025 14:13
Copy link
Member

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jobo322 No testcase were change if I understood well, just new one. So this PR is good for me.
Please fix the testcase. new rule that force us in package.json to exports
{ ".": "./lib/index.js" } like in https://github.com/mljs/signal-processing/blob/main/package.json#L7

@jobo322 jobo322 merged commit 11370e8 into main Sep 22, 2025
10 checks passed
@jobo322 jobo322 deleted the 131-wrong-selection-of-the-peak-center-when-there-is-two-ddy-into-the-same-dy-min-max branch September 22, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong selection of the peak center when there is two DDY into the same DY min-max

3 participants