mlflow 2.0 compatibility #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shrinath Suresh <[email protected]>
Signed-off-by: Shrinath Suresh <[email protected]>
Signed-off-by: Shrinath Suresh <[email protected]>
…into mlflow-2.0-compatibility Signed-off-by: Shrinath Suresh <[email protected]>
Signed-off-by: Shrinath Suresh <[email protected]>
Signed-off-by: Shrinath Suresh <[email protected]>
Signed-off-by: Shrinath Suresh <[email protected]>
shrinath-suresh
changed the title
7 tasks
shrinath-suresh
commented
Dec 21, 2022
| self.train_acc = Accuracy() | ||
| self.val_acc = Accuracy() | ||
| self.test_acc = Accuracy() | ||
| self.train_acc = Accuracy(task="multiclass", num_classes=3) |
Collaborator
Author
There was a problem hiding this comment.
Latest torchmetrics expects task and num_classes to be passed while using Accuracy - https://torchmetrics.readthedocs.io/en/stable/classification/accuracy.html
dbczumar
reviewed
Jan 12, 2023
| _DEFAULT_TORCHSERVE_LOCAL_MANAGEMENT_PORT = "8081" | ||
|
|
||
|
|
||
| class CustomPredictionsResponse(PredictionsResponse): |
There was a problem hiding this comment.
Nit: Do we want to call this TorchServePredictionsResponse?
Collaborator
Author
|
Hi, are you still considering this PR? |
Collaborator
Author
|
@chauhang Can you please review and approve the PR so that we can merge ? |
chauhang
approved these changes
Feb 12, 2023
Collaborator
Author
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shrinath Suresh [email protected]
What changes are proposed in this pull request?
MLflow 2.0 compatibility with latest PT and PTL
How is this patch tested?
Titanic
titanic_training.txt
Iris Classification
iris_training.txt
iris_training_gpu.txt
IrisClassification - Torchscripted
iris_torchscript_training.txt
MNIST
mnist_training.txt
mnist_training_gpu.txt
CIFAR
cifar_training.txt
cifar_training_gpu.txt
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s) does this PR affect?
Components
area/deploy: Main deployment plugin logicarea/build: Build and test infrastructure for MLflow TorchServe Deployment Pluginarea/docs: MLflow TorchServe Deployment Plugin documentation pagesarea/examples: Example codeHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes