-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on render callback #1050
Open
albertywu
wants to merge
134
commits into
mleibman:master
Choose a base branch
from
SimplGy:add-onRender-callback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add on render callback #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sirable because qUnit does not guarantee order.
… update only the widths of things. Still takes a columnDefinitions object.
expose 'setupColumnResize' method
Add support for Slick Ranges toCell, toRow equal to Infinity.
…sed for column headers. It's a callback that receives a column object and should return a jquery-wrapped dom element.
…he slick grid instance they're working with. Useful for managing multiple instances on a single page.
…umnsChanged`. You can pass options that will be sent to your event handlers.
…alculation. Useful perf boost if you know the width and that only that changed.
…calculated that content should grow them), not just when the user drags to resize.
…, or if columns aren't pinned
…an explanation of the break
…b headers are rebuilt.
… is pinned--we can assume those are always in view on that dimension.
…iewport. We now listen to scroll events from both left and right and set the same value on both when a scroll happens. Had to change the overflow setting on the pinned area so that it would throw events. Hiding the scroll bar using css on the .pinned class makes this visually OK.
… scroll over that. Leverages `mousewheel`, which we understand is a non-standard event: https://developer.mozilla.org/en-US/docs/Web/API/MouseWheelEvent
hide scrollbars on pinned columns
…croll add antiscroll support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bcherny can you take a look?