Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish wheels #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

publish wheels #52

wants to merge 1 commit into from

Conversation

dimbleby
Copy link

@dimbleby dimbleby commented Feb 3, 2025

Publish wheels

I can only guess that the rm dist/*.whl was left over from some debugging? I see no reason to avoid publishing wheels.

@dimbleby dimbleby requested a review from a team as a code owner February 3, 2025 20:00
Copy link

github-actions bot commented Feb 3, 2025

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact [email protected].
0 out of 1 committers have signed the MLCommons CLA.
@dimbleby
You can retrigger this bot by commenting recheck in this Pull Request

@dimbleby
Copy link
Author

dimbleby commented Feb 3, 2025

I will not be signing a CLA, you are welcome to this contribution, take it or leave it.

@arjunsuresh
Copy link
Contributor

@dimbleby That's added to force a src build on user systems. We need to execute a custom command to pull a git repository and so this is needed.

@dimbleby
Copy link
Author

dimbleby commented Feb 3, 2025

I do not see where your build does that? You have no setup.py, the build looks to me to be completely statically defined (which is good!)

There is some git clone happening in mlc/main.py - but that happens at runtime, not at build time?

@arjunsuresh
Copy link
Contributor

My bad. You're correct. I was mixing the build on another repository mlperf-automations. Unfortunately mlcommons won't allow any PR to be merged until CLA is signed :( This is to make sure that every code under mlcommons is Apache2.

@dimbleby
Copy link
Author

dimbleby commented Feb 3, 2025

well that is too much trouble for me but feel free to take this and rework it to whatever extent you feel is necessary to satisfy your license.

It sure would be a shame if me offering this actually blocked you from doing it!

@arjunsuresh
Copy link
Contributor

Sure no worries. Thank you for notifying us 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants