-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish wheels #52
base: main
Are you sure you want to change the base?
publish wheels #52
Conversation
MLCommons CLA bot: |
I will not be signing a CLA, you are welcome to this contribution, take it or leave it. |
@dimbleby That's added to force a src build on user systems. We need to execute a custom command to pull a git repository and so this is needed. |
I do not see where your build does that? You have no setup.py, the build looks to me to be completely statically defined (which is good!) There is some git clone happening in mlc/main.py - but that happens at runtime, not at build time? |
My bad. You're correct. I was mixing the build on another repository |
well that is too much trouble for me but feel free to take this and rework it to whatever extent you feel is necessary to satisfy your license. It sure would be a shame if me offering this actually blocked you from doing it! |
Sure no worries. Thank you for notifying us 😊 |
Publish wheels
I can only guess that the
rm dist/*.whl
was left over from some debugging? I see no reason to avoid publishing wheels.