Skip to content

Merge Dev#249

Open
arjunsuresh wants to merge 11 commits into
mainfrom
dev
Open

Merge Dev#249
arjunsuresh wants to merge 11 commits into
mainfrom
dev

Conversation

@arjunsuresh

Copy link
Copy Markdown
Contributor

✅ PR Checklist

  • Target branch is dev

📌 Note: PRs must be raised against dev. Do not commit directly to main.

✅ Testing & CI

  • Have tested the changes in my local environment, else have properly conveyed in the PR description
  • The change includes a GitHub Action to test the script(if it is possible to be added).
  • No existing GitHub Actions are failing because of this change.

📚 Documentation

  • README or help docs are updated for new features or changes.
  • CLI help messages are meaningful and complete.

📁 File Hygiene & Output Handling

  • No unintended files (e.g., logs, cache, temp files, pycache, output folders) are committed.

🛡️ Safety & Security

  • No secrets or credentials are committed.
  • Paths, shell commands, and environment handling are safe and portable.

🙌 Contribution Hygiene

  • PR title and description are concise and clearly state the purpose of the change.
  • Related issues (if any) are properly referenced using Fixes # or Closes #.
  • All reviewer feedback has been addressed.

@arjunsuresh arjunsuresh requested a review from a team as a code owner June 13, 2026 12:09
@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the GitHub workflow and documentation accordingly. It also improves the installer script by conditionally adding the branch checkout argument only if specified, preventing potential errors. Additionally, the Action class in mlc/action.py is refactored to safely handle index entries with invalid metadata by skipping them and logging a warning, improving robustness. The version is bumped from 1.2.3 to 1.2.4. Risks are low but include potential breakage if any references to the old installer script name are missed. The design improvements enhance error handling and script flexibility.

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the GitHub workflow and documentation accordingly. It also improves the installer script by making the branch checkout optional in the pull_repo function. Additionally, the Action class in mlc/action.py is refactored to handle invalid meta data gracefully by skipping such items, improving robustness. The README badges are updated to point to the dev branch, and the version is bumped from 1.2.3 to 1.2.4. Overall, the changes are low risk but require careful validation of the installer script URL updates and the new optional branch logic to avoid breaking installs or CI workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants