-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added metrics for BraTS Path challenge #885
base: new-apis_v0.1.0-dev
Are you sure you want to change the base?
Added metrics for BraTS Path challenge #885
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is fine now, good idea with adding average type to the metric name. LGTM
…e for metrics that do not need average. also, output dict updated to remove overwriting
Thanks for the review, @szmazurek! I will wait for @Geeks-Sid and @vpchung to test this before merging. |
The test failure is related to #889. |
Setup clean
…hub.com/sarthakpati/GaNDLF into new-apis_v0.1.0-dev__brats-path_metrics
Fixes #817
Proposed Changes
auroc
has been fixedmcc
) from torchmetricsmcc
)auroc
gets testedChecklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].