-
Notifications
You must be signed in to change notification settings - Fork 89
feat: add common version file for dockerfile #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
- Coverage 82.30% 82.25% -0.05%
==========================================
Files 193 193
Lines 12314 12314
==========================================
- Hits 10135 10129 -6
- Misses 2179 2185 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { | ||
| "python": "3.11", | ||
| "pytorch": { | ||
| "version": "2.7.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to pick up the pytorch version from setup.py so that there is a single point of reference?
| "torchvision": "0.22.1", | ||
| "torchaudio": "2.7.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these versions are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks. I believe they are coming from the PyTorch install page [ref], where each PT version has an associated vision/audio dependency. Any way we can this more seamless? Would just putting torchvision and torchaudio in the pip command without versions work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the name to versions_docker.json so that the purpose of the file is clear?
Fixes #ISSUE_NUMBER
Proposed Changes
Checklist
CONTRIBUTINGguide has been followed.typingis used to provide type hints, including and not limited to usingOptionalif a variable has a pre-defined value).pip installstep is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].logginglibrary is being used and noprintstatements are left.