Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate LAPACK exception codes to an actionable error message. #1795

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NAThompson
Copy link
Contributor

@NAThompson NAThompson commented Jan 25, 2025

Checklist

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works

@angeloskath
Copy link
Member

As I mentioned in #1794 (and as the comment above the check mentions) I think we should not throw when a matrix is not positive semi-definite since this can't be caught and will result in a crash.

@awni
Copy link
Member

awni commented Jan 28, 2025

Agreed, we shouldn't throw for non-PSD matrices. Maybe there are a couple other options we can think about (though not necessarily for this PR):

  • Have a hard assert mode, when you run you code and a detectable error happens (like this or in indexing reading/writing out of bounds) there is a hard crash. Could toggle that with a env flag
  • Could fill the output with NaN in the case of non-PSD matrices rather than a partially computed Q/R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants