Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible implementation of multithreaded streams for the CPU.
I'm not entirely sure if 1. we should add it and 2. If this is a good way. There are some niche cases where it's useful to have a multi-threaded stream (like quantizing on a CPU-only machine).
On an M3 Max quantizing 8B Llama 3 to 4-bit with the CPU:
Interestingly using the CPU-only build is much faster 🤔
With #1578 and 8 threads the CPU quantization time is 4.6 seconds.. which is pretty good for CPU only. Almost as fast as the GPU which is 3.03 seconds on the M3 max.