Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct handling of no-image case for qwen2-vl #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidkoski
Copy link
Collaborator

@davidkoski davidkoski requested a review from awni January 14, 2025 18:39
@@ -783,7 +783,7 @@ public class Qwen2VL: Module, VLMModel, KVCacheDimensionProvider {
-> MLXArray
{
guard let pixelValues, let gridThw else {
return languageModel(inputIds).logits
return languageModel.model.embedTokens(inputIds[.newAxis, .ellipsis])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text-only prompts don't work for VLMs
1 participant