-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chat template #135
Use chat template #135
Conversation
Using the chat templates with Llama 3.2 will result in an error until |
OK, should we hold off on taking this until that is merged (and we can pick it up here)? |
Yes, since LLMEval includes model configs for Llama 3.2. In the meantime, this branch can be used to test Llama 3.2 with the work in progress on Jinja. |
|
The problem with Mistral 7B is resolved here: huggingface/swift-transformers#134 |
8e36c71
to
24223b2
Compare
24223b2
to
07ce9a6
Compare
Llama 3.2 1B and 3B and Mistral 7B now work with chat templates, thanks to the changes in swift-transformers and Jinja. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Since huggingface/swift-transformers#104, it's now possible to use the chat template from
tokenizer_config.json
.I've updated LLMEval to use the chat template, but I noticed that the output from the Mistral models ends with<|im_end|>
, even when this string is included inextraEOSTokens
. Perhaps @pcuenca has an idea why this might be happening?