feat(dev) Support query predicates for graph commit command #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a Node you can specify a predicate via withQueryPredicate() or optional constructor parameter. When not specified the default predicate is MATCH. When creating an edge, you can use the Edge::create() or Edge::merge() methods to determine the strategy.
jblotus
commented
Jun 29, 2021
| $graph->addEdge($edge); | ||
| $query = $graph->getCommitQueryWithMerge(); | ||
| $this->assertEquals( | ||
| 'MATCH (CatOwner:person {name: "John Doe", age: 33, gender: "male", status: "single"}) ' . |
There was a problem hiding this comment.
notice the match match merge here
jblotus
commented
Jun 29, 2021
| $content = ob_get_clean(); | ||
| echo $content; | ||
| $expectedLines = <<<EOT | ||
| ----------------------------------------- |
There was a problem hiding this comment.
these tests were a little tricky to update but I'm glad they are here!
jblotus
commented
Jun 29, 2021
| @@ -104,4 +113,9 @@ private function getPropValueWithDataType($propValue) | |||
| } | |||
| return (int) $propValue; | |||
| } | |||
|
|
|||
| public function getQueryPredicate(): string | |||
There was a problem hiding this comment.
this bit is important that i set it to default to MATCH to preserve existing behavior
|
I'll try to review this in a couple of days. I have ideas that can be applied after this PR. |
|
No rush please - this is merely some ideas I had. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a Node you can specify a predicate via withQueryPredicate()
or optional constructor parameter. When not specified the default predicate
is MATCH.
When creating an edge, you can use the Edge::create() or
Edge::merge() methods to determine the strategy.