This repository was archived by the owner on Nov 2, 2024. It is now read-only.
Accessibility fix, switch attribute from "lang" to "data-lang" #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
force-pushed
the
update/data-lang
branch
from
1226492 to
fc8868b
Compare
- Adds the old attribute to deprecation for lang="javascript" this is supposed to migrate to data-lang="javascript" - Add old save function NOTE: This does not work, an old block still shows as invalid.
|
I've determined the cause of why this deprecation is not working and filed a ticket at: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IN PROGRESS
This PR does not work as expected, if using an older block with the "lang" attribute, the deprecation does not get run and the attribute does not get read or converted properly.
To test: