Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/sc 232 refactor code #24

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Improvement/sc 232 refactor code #24

merged 6 commits into from
Jan 24, 2024

Conversation

lgaljer20
Copy link
Collaborator

Changes made:

  1. Changed policy restriction for GetAllChargers endpoint
  2. Changed GetAllChargers to return descending list by creationTime
  3. Changed methods for returning charging history to return descending lists by event's endTime
  4. Secured connection string to database with github secrets
  5. Fixed authentication settings
  6. Added code to apply pending migration when application is started

All previous tests and newly added tests have successfully passed. ✅

@lgaljer20 lgaljer20 added the improvement Better/cleaner code for scalability and maintainability of already existing task. label Jan 24, 2024
@lgaljer20 lgaljer20 self-assigned this Jan 24, 2024
lraknic20
lraknic20 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@lraknic20 lraknic20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

mkajic20
mkajic20 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Owner

@mkajic20 mkajic20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@mkajic20 mkajic20 merged commit 56cdbdd into develop Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkajic20 mkajic20 mkajic20 approved these changes

@lraknic20 lraknic20 lraknic20 approved these changes

Assignees

@lgaljer20 lgaljer20

Labels
improvement Better/cleaner code for scalability and maintainability of already existing task.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgaljer20 @mkajic20 @lraknic20