Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/sc 230 google login #23

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Conversation

lgaljer20
Copy link
Collaborator

Updated authentication flow for Google login. Refactored GoogleAuthService to use authorization code for getting users info.

Changes made:

  1. Changed implementation in GoogleAuthService
  2. Changed code in GoogleLoginService to adjust to GoogleAuthService
  3. Update GoogleLoginController
  4. Adjusted unit tests for GoogleLoginService

All previous tests and newly added tests have successfully passed. ✅

@lgaljer20 lgaljer20 added the improvement Better/cleaner code for scalability and maintainability of already existing task. label Jan 17, 2024
@lgaljer20 lgaljer20 self-assigned this Jan 17, 2024
Copy link
Owner

@mkajic20 mkajic20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good.

Copy link
Collaborator

@lraknic20 lraknic20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Now you can login or register with ServerAuthCode.

@lraknic20 lraknic20 merged commit 850c97b into develop Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Better/cleaner code for scalability and maintainability of already existing task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants