로그인 상태/라운지 참여여부 #114
Open
로그인 상태/라운지 참여여부 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeon2565
reviewed
Jul 25, 2022
syeon2565
reviewed
Jul 26, 2022
src/pages/lounge/index.tsx
Outdated
|
|
||
| // 로그인 하지 않은 상태로 라운지 진입시 | ||
| useEffect(() => { | ||
| if (!getCookie('jwt')) Router.push('/sign-in'); |
ndaemy
requested changes
Jul 26, 2022
Bhanjo
reviewed
Aug 11, 2022
src/pages/lounge/index.tsx
Outdated
Comment on lines
43
to
67
| const statusVerify = async () => { | ||
| try { | ||
| // 내가 소속된 라운지 리스트 | ||
| const loungeList = await Axios.get(`https://api.liontown.city/api/lounges`, { | ||
| withCredentials: true, | ||
| }); | ||
| // 선택한 라운지 정보 -> {id} 부분에 임시로 값 넣음 | ||
| const selectLounge = await Axios.get(`https://api.liontown.city/api/lounges/sgIG8L`, { | ||
| withCredentials: true, | ||
| }); | ||
| // console.log(selectLounge.data.data.roomData); | ||
| // 내가 소속된 라운지 리스트명과 선택한 라운지가 같지 않을 때 | ||
| // 혹은 해당 라운지가 없는 경우 라운지 생성페이지로 보내기 | ||
| if ( | ||
| loungeList.data.data[0].name !== selectLounge.data.data.loungeName.name || | ||
| selectLounge.status === 404 | ||
| ) { | ||
| useRouter.push('/lounge-select'); | ||
| setTimeout(() => returnLoungeSelect(), 2000); | ||
| } | ||
| } catch (err) { | ||
| // console.log 없앨 예정 .. | ||
| console.log('error'); | ||
| } | ||
| }; |
There was a problem hiding this comment.
get 요청은 리액트 쿼리를 써주세요
api 패치를 한번에 두 개를 하는데 이 둘을 동기적으로 다룰 것이 아니라면 분리해주세요
syeon2565
reviewed
Aug 12, 2022
| selectLounge.status === 404 | ||
| ) { | ||
| useRouter.push('/lounge-select'); | ||
| setTimeout(() => returnLoungeSelect(), 2000); |
syeon2565
reviewed
Aug 13, 2022
Bhanjo
reviewed
Aug 13, 2022
Comment on lines
+57
to
+64
| useEffect(() => { | ||
| if (getCookie('jwt')) { | ||
| router.push('/sign-in'); | ||
| returnMessage(); | ||
| } else { | ||
| statusVerify(); | ||
| } | ||
| }, []); |
There was a problem hiding this comment.
httpOnly 설정으로 인해 프론트에서 쿠키 조작 불가합니다 axios나 리액트 쿼리에서 에러 핸들러로 로그인 검증 해주세요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.