Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JasmineGraph Frontend Shell #254

Merged
merged 31 commits into from
Jan 14, 2025
Merged

Conversation

ChandiH
Copy link
Contributor

@ChandiH ChandiH commented Sep 17, 2024

  • implement jasminegraph frontend ui shell ( running in port 7776 )
  • seperate common frontend util functions

Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put some comments. Please address them all and reply to each of the comments explaining how you addressed them.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 566 lines in your changes missing coverage. Please review.

Project coverage is 1.30%. Comparing base (5538e94) to head (e8d85e7).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/ui/JasmineGraphFrontEndUI.cpp 0.00% 361 Missing ⚠️
...rontend/core/common/JasmineGraphFrontendCommon.cpp 0.00% 131 Missing ⚠️
src/frontend/JasmineGraphFrontEnd.cpp 0.00% 32 Missing ⚠️
src/util/Utils.cpp 0.00% 29 Missing ⚠️
src/server/JasmineGraphServer.cpp 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #254      +/-   ##
=========================================
- Coverage    1.31%   1.30%   -0.01%     
=========================================
  Files          77      79       +2     
  Lines       15432   15819     +387     
  Branches     9839   10092     +253     
=========================================
+ Hits          203     207       +4     
- Misses      15028   15408     +380     
- Partials      201     204       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
6.0% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@miyurud
Copy link
Owner

miyurud commented Dec 10, 2024

@ChandiH Please put a comment for each of the comments resolved explaining how those were resolved.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
5.9% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@miyurud miyurud merged commit 6bc8c99 into miyurud:master Jan 14, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants