fix(Library): Fixed playlist name incorrectly used as path for importing #15671
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importers build TreeItems with the name of the playlist as the label and the path to the playlist as data. Therefore createPlaylistModelForPlaylist() should get the data member of the TreeItem and not the label in order for the playlist to be found.
Per coding standard
DidierMalenfant
changed the title
ronso0
reviewed
Nov 24, 2025
Comment on lines
+169
to
+171
| const auto* pTreeItem = static_cast<TreeItem*>( | ||
| m_lastRightClickedIndex.internalPointer()); | ||
| *pPlaylist = pTreeItem->getLabel(); |
Member
There was a problem hiding this comment.
Suggested change
| const auto* pTreeItem = static_cast<TreeItem*>( | |
| m_lastRightClickedIndex.internalPointer()); | |
| *pPlaylist = pTreeItem->getLabel(); | |
| const auto* pTreeItem = static_cast<TreeItem*>( | |
| m_lastRightClickedIndex.internalPointer()); | |
| VERIFY_OR_DEBUG_ASSERT(pTreeItem) { | |
| return; | |
| } | |
| *pPlaylist = pTreeItem->getLabel(); |
Author
|
I need to test this with other importers like rekordbox or Serato because it looks like If that's the case then this would break those other importers which would now receive a playlist ID or path from I'll investigate more and report back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #15645, library importers build TreeItems with the name of the playlist as the label and the path to the playlist as data. Therefore createPlaylistModelForPlaylist() should get the data member of the TreeItem and not the label in order for the playlist to be found during import.