Skip to content

Conversation

@acolombier
Copy link
Member

This addresses #15437 and honour the agreed plan regarding QML feature on main

@github-actions github-actions bot added the build label Oct 19, 2025
@acolombier acolombier linked an issue Oct 19, 2025 that may be closed by this pull request
@acolombier acolombier added this to the 2.7-beta milestone Oct 19, 2025
@acolombier acolombier force-pushed the chore/rename-qml-arg branch from d75430f to 55e90ca Compare October 20, 2025 12:45
forUserFeedback ? QCoreApplication::translate("CmdlineArgs",
"Loads experimental QML GUI instead of legacy QWidget skin")
: QString());
const QCommandLineOption qml(QStringLiteral("next"),
Copy link
Member

@Holzhaus Holzhaus Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not involved in the discussion, but isn't --next even more cryptic? Could basically mean everything (e.g., "play next track").

If you think it's too technical, maybe consider --new-user-interface or something like that?

Also, keep in mind that contributors will likely still use the term "QML" to refer to the new UI, so I am wondering if it's really that cryptic after all.

I'm happy with whatever name you think fits, I just wanted to point this out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good shout, I didn't think of the "Next" in the context of a player which is very relevant to Mixxx. I think --new-user-interface is a good shout!

Also, keep in mind that contributors will likely still use the term "QML" to refer to the new UI, so I am wondering if it's really that cryptic after all.

Note that --qml will continue working, at least for some time! But technically, this remains implementation details; the fact that contributors or technical-aware people continue referencing it is this way is fine tho - I surely will continue calling it QML :)

However, for less technical user, this feels unnecessary confusing, especially now that QML is also used in the legacy UI (for controller offscreen rendering)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the --qml flag

2 participants