Skip to content

Conversation

@acolombier
Copy link
Member

@acolombier acolombier commented Oct 15, 2025

Since GH has no ability to specify which even is required for a required actions and skipped actions are considered successful (:grimacing:), this aims to restore auto-merge capability to using to explicit workflow for branch and PR, and remove the "Ready for merge" from the branch workflow

(Test edit)

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's try it. Thank you.

@daschuer
Copy link
Member

The CI of this branch does not run. I have tried to edit the initial post as usually, but it does not restart the CI.

@acolombier
Copy link
Member Author

I believe this is because it isn't merged yet - Actions will get created when merging, so right now the pull_request event didn't register yet. You should be able to test it in your fork

@daschuer
Copy link
Member

daschuer commented Nov 8, 2025

Tested in my private repository and got:

 Invalid workflow file: .github/workflows/pr.yml#L1
(Line: 20, Col: 9): Job 'pre-commit' depends on unknown job 'stop-build'., (Line: 27, Col: 9): Job 'checks' depends on unknown job 'stop-build'., (Line: 35, Col: 9): Job 'build' depends on unknown job 'stop-build'., (Line: 46, Col: 9): Job 'ready' depends on job 'pre-commit' which creates a cycle in the dependency graph., (Line: 47, Col: 9): Job 'ready' depends on job 'checks' which creates a cycle in the dependency graph., (Line: 49, Col: 9): Job 'ready' depends on job 'build' which creates a cycle in the dependency graph.

https://github.com/daschuer/mixxx/actions/runs/19197911532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants