Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small grammar fix for comment in BpmControl::slotUpdateRateSlider #14344

Merged

Conversation

cr7pt0gr4ph7
Copy link
Contributor

@cr7pt0gr4ph7 cr7pt0gr4ph7 commented Feb 14, 2025

You can't get more minimal than updating just 3 characters. The title already contains more characters than the change itself 😅

Anyway, this is just a leftover from another larger changeset that is currently being split up.

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM!

@ronso0
Copy link
Member

ronso0 commented Feb 14, 2025

no need to wait for clang-tidy..

@ronso0 ronso0 merged commit 1173645 into mixxxdj:main Feb 14, 2025
13 checks passed
@cr7pt0gr4ph7 cr7pt0gr4ph7 deleted the ready-for-merge/engine-controls/bpm-control branch February 14, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants