Add links to important guidelines to CONTRIBUTING.md #14342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Feb 14, 2025
cr7pt0gr4ph7
force-pushed
the
ready-for-merge/add-developer-guidelines
branch
2 times, most recently
from
788de29 to
99f5002
Compare
cr7pt0gr4ph7
force-pushed
the
ready-for-merge/add-developer-guidelines
branch
from
99f5002 to
5b0cdef
Compare
acolombier
reviewed
Feb 15, 2025
| @@ -48,7 +56,7 @@ All of these are automatically built and deployed by [GitHub Actions](https://gi | |||
|
|
|||
| Refer to [How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/) for more details. | |||
|
|
|||
| * Install [pre-commit](https://pre-commit.com/#install) to automatically ensure that your commits comply with our code style for both C++ and JavaScript. This saves time reviewing so we don't have to point out nitpicky style issues. Once you have pre-commit installed on your computer, set it up in your local Git repository: | |||
| * <a name="pre-commit"></a> Install [pre-commit](https://pre-commit.com/#install) to automatically ensure that your commits comply with our code style for both C++ and JavaScript. This saves time reviewing so we don't have to point out nitpicky style issues. Once you have pre-commit installed on your computer, set it up in your local Git repository: | |||
There was a problem hiding this comment.
Why not using a heading here rather than making an anchor this way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13827