-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(usability) Waveform prefs: group options, adjust tabstops, reorder ui file #13615
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't really comment much on the ui file changes but ur in the expert in that anyways so there is not much to argue here
7410ec2
to
2b341bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thank you. Does anyone want to look at the ui file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This is already an improvement.
Here some comments:
- The Group box lable "Wavform" can become "Scrolling Wavewform" or such, to better distinguished it from the "Waveform Overview".
- The checkboxes around the Waveform comobox are looking spreaded. Can we put the m all in one line?
- The title column in both group boxes are not aligned.
- If you disable the waveforms, it feels random what is grayed out and what not. In addition the hint about missing accelerations appears. Do we need to gray out anything at all? In case of a crashing config, the user may want to keep the checkbox disabled, adjust the settings an than enable.
If you prefer to merge it as it is, just give a hint.
Fixed. |
I torn about this. Therefore, IMO all (scrolling) waveform options should be grayed out. |
Yep, fixed. |
2b341bb
to
115a7fd
Compare
Fixed. |
This improves usability in the waveform preferences by grouping the options:
Waveforms / Overview / Caching /OpenGl info
The checkbox
[ ] Enabled
looks a bit weird in the 2nd column. Could as well be
Enabled [ ]
(in 1st column)Note:
Unfortunately there is an issue with QGroupBox: it seems to have some minimal height which is not reached with 3 items, which in turn unnecessarily expands the group box. A spacer at the bottom of the page fixes this, downside is the extra space at the bottom (didn't manage to minimize that..)