pre-commit: Ignore time stamps in po files #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
added a commit
that referenced
this pull request
Dec 29, 2024
…ing ignore_pot_creation_date.py from #708
…p has changed It helps to create meaningful commits, instead of up to 4100 changed files.
daschuer
force-pushed
the
tx_precommit
branch
from
8a6c2dc to
f55ece4
Compare
daschuer
force-pushed
the
tx_precommit
branch
from
f55ece4 to
a63a82d
Compare
|
It has been used here: |
Holzhaus
reviewed
Dec 30, 2024
| ) | ||
|
|
||
|
|
||
| def revert_po_file(changeset, po_file, logger): |
There was a problem hiding this comment.
makes no sense to pass a logger here, getLogger is cheap
Comment on lines
+61
to
+62
| proc = subprocess.run(cmd, capture_output=True, text=True) | ||
| proc.check_returncode() |
There was a problem hiding this comment.
looks like you want this:
Suggested change
| proc = subprocess.run(cmd, capture_output=True, text=True) | |
| proc.check_returncode() | |
| output = subprocess.check_output(cmd, text=True) |
| ) | ||
| parser.add_argument("--from-ref", help="Use changes since this commit.") | ||
| parser.add_argument("--to-ref", help="Use changes until this commit.") | ||
| parser.add_argument("files", nargs="*", help="Only check these files.") |
There was a problem hiding this comment.
Suggested change
| parser.add_argument("files", nargs="*", help="Only check these files.") | |
| parser.add_argument("files", nargs="*", type=pathlib.Path, help="Only check these files.") |
| return f"{from_ref}...{to_ref}" if to_ref else from_ref | ||
|
|
||
|
|
||
| def count_meaningful_changes(changeset, po_file) -> int: |
There was a problem hiding this comment.
Suggested change
| def count_meaningful_changes(changeset, po_file) -> int: | |
| def count_meaningful_changes(changeset: str, po_file: typing.Iterable[pathlib.Path]) -> int: |
| proc = subprocess.run(cmd, capture_output=True, text=True) | ||
| proc.check_returncode() | ||
|
|
||
| with open(po_file, "w") as file: |
There was a problem hiding this comment.
if po_file is a Path, you can do this:
Suggested change
| with open(po_file, "w") as file: | |
| with po_file.open(mode="w") as file: |
Comment on lines
+82
to
+83
| # Remove the first entry which is the script file name itself | ||
| files_to_process = args.files[1:] if args.files else [] |
There was a problem hiding this comment.
I don't think this is correct. Are you confusing this with sys.argv?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I revert normally manually time stamp only changes, to avoid cluttering a commit wit 4100 changed files. This is tedious and error prone. This PR automates it.