Repository navigation
chore: bump setup-ruby and pin test matrix to ubuntu-24.04 - #178
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 16 16
Lines 885 885
=======================================
Hits 861 861
Misses 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ubuntu-latest now resolves to ubuntu-26.04. The pinned setup-ruby v1.269.0 does not recognise that image, so every Set up Ruby step failed. Bump to v1.338.0, which supports 26.04. That image only has prebuilt CRuby >= 3.2, so pin the test jobs to ubuntu-24.04 to keep 3.0/3.1 coverage, and disable fail-fast so one version's failure no longer cancels the rest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
44bcc83 to
99925c7
Compare
[Medium impact] The PR appears safe to merge. Reviews (1) · Last reviewed commit: "chore: bump setup-ruby and pin test matr..." · Reviewed by Greptile |
ketanmixpanel
left a comment
There was a problem hiding this comment.
LGTM. Pinning setup-ruby to v1.338.0 by SHA and moving to ubuntu-24.04 keeps Ruby 3.0 and 3.1 in the matrix, and fail-fast: false is a good change.
Local run on this branch (Ruby 3.2.2): core 407 examples, 0 failures, 2 pending (also pending on master); openfeature-provider 62 examples, 0 failures.
Nit: the 24.04 pin will go stale quietly. Worth a ticket for the Ruby 3.0/3.1 drop decision you list as a follow-up.
|
The goal was to unblock the other PRs from CI failures. If this becomes an issue in future, we could pick it up as a new task. Should be straight forward. |
|
Thanks @ketanmixpanel! Agreed. The 24.04 pin should be revisited along with the Ruby 3.0/3.1 drop decision, and that'll get a follow-up ticket. |
Problem
Every
test (3.x)andtest-openfeature (3.x)job fails within seconds atSet up Ruby. Master is affected too (run 41891871527), and so is #177.ubuntu-latestnow resolves toubuntu-26.04. The pinnedruby/setup-rubyv1.269.0 doesn't recognise that image: it logsThe current runner (ubuntu-26.04-x64) was detected as self-hosted. Fail-fast then cancels the remaining versions.Fix
ruby/setup-rubyto v1.338.0 (latest, pinned by SHA) inruby.ymlandrelease-rubygems.yml. This release listsubuntu-26.04as supported. (prepare-release.ymldoesn't use setup-ruby.)testandtest-openfeaturetoruns-on: ubuntu-24.04. Per the setup-ruby README,ubuntu-26.04only has prebuilt CRuby 3.2 and newer, because older CRuby doesn't compile there. Pinning keeps 3.0 and 3.1 in the matrix.fail-fast: falseon both matrices so a failure on one Ruby version no longer cancels the others.The release workflow uses Ruby 3.3, so it can stay on
ubuntu-latestwith the bumped action.Follow-up (not in this PR)
Ruby 3.0 and 3.1 are EOL, and the current runner image no longer has builds for them. The 24.04 pin keeps them working for now. Whether to drop them from the matrix and gemspec is a product decision.
🤖 Generated with Claude Code