Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 #53

Closed
wants to merge 3 commits into from
Closed

2.0.0 #53

wants to merge 3 commits into from

Conversation

YuriiChikhrai
Copy link

Update all dependencies and fix code to new versions.

@mixn
Copy link
Owner

mixn commented Jan 29, 2020

Hi, thanks for opening! :)

This is too big of a change for me to merge any time soon, if ever. Having only one commit doesn’t help with this, I think. 😢 I might take a look at it some time though, currently quite swamped. Thank you for your PR! :) @YuriiChikhrai

PS: Kay…? 😄 https://dsh.re/1b7911
PPS: It took me a long time to figure out who you are @YuriiChikhrai, lol. Hope you’re good! 🤜🤛

@YuriiChikhrai
Copy link
Author

I change code little bit only for new versions of packages, because update of major versions break functionality... Core stay the same.
The hardest was to update xo and ava... It was several hours to make able push code into repo, because husky not allow it without tests...

PS: It will be cool to use something like prettier in project, when I use it, it change a lot of lines in all files, so I return old style...

PSS: You can not confirm this https://dsh.re/1b7911 )

@finncyr
Copy link

finncyr commented Mar 2, 2020

The installation with npm i -g of the original repo was not successful on my maschine. I cloned the fork from YuriiChikhrai and can confirm it runs smoothly without any problems. (tested as well)

OS: Ubuntu 19.10

@mixn
Copy link
Owner

mixn commented Mar 2, 2020

@finncyr I’ll try to take a look at it soon.

This is tested and used to work flawlessly on Ubuntu. 😞

@finncyr
Copy link

finncyr commented Mar 5, 2020

There seems to be a problem getting/building puppeteer but i could not quite resolve/identify it

@mixn
Copy link
Owner

mixn commented Feb 6, 2023

Sorry I never took a look at this. Slowly coming back to this side project. 🙂 This will be addressed in #83 by being able to be used offline. 🙂 Thank you for your time, and sorry again for the late response!

@mixn mixn closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants