Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language-map: add support for plain text (.txt) #52

Closed
wants to merge 1 commit into from

Conversation

felixge
Copy link

@felixge felixge commented Jan 26, 2020

I was just trying to render some plain text files in carbon-now and the auto language detection decided on some weird coloring that doesn't make sense to me. Hopefully 'text' is a better default for .txt files.

I was just trying to render some plain text files in carbon-now and the auto language detection decided on some weird coloring that doesn't make sense to me. Hopefully 'text' is a better default for .txt files.
@mixn
Copy link
Owner

mixn commented Jan 29, 2020

I’ll take a look at this soon, currently quite swamped. Thank you for your PR! :) @felixge

@josinalvo
Copy link

@felixge You probably want to fiddle with carbon-now-cli/src/helpers/language-map.json

To see where npm has installed your package, try npm list -g

(idk about other package managers)

@felixge
Copy link
Author

felixge commented Feb 24, 2020

@josinalvo thanks for your suggestion, but isn't that exactly what this PR is doing? : )

@josinalvo
Copy link

@felixge sure, I just found a stopgap measure for myself (for another question) and thought it could be useful for you as well

@mixn
Copy link
Owner

mixn commented Feb 6, 2023

Sorry I never took a look at this. Slowly coming back to this side project. 🙂 I’ve started work on #83 and will look at this PR before I move too far away from the current state of the code base. I’ll either merge or close this soon, just fyi. Closing will happen if I decide to approach the issue differently as part of the v2 update.

Thank you again for your time!

@mixn
Copy link
Owner

mixn commented May 12, 2023

@felixge I’m finalizing the huge v2 release, and since literally everything is new ™ I happened to just add it since I had to cover tons of other languages still anyway.

I don’t want to be taking away from you as a contributor, though, so pls let me know how you wanna proceed. If you’re fine with just closing this PR, that’s okay with me, but I can also remove the line, and you can submit a new PR once the v2 branch is merged into master.

carbon-now-cli isn’t using https://github.com/all-contributors/cli/ (yet), otherwise you could have just added yourself there, even if we closed the PR.

Happy to hear your thoughts. :)

@felixge
Copy link
Author

felixge commented May 15, 2023

Hey @mixn thanks for your message, it's very kind! Let's just close this. I'm happy to hear a new version is coming and that plain text will be supported 🙇.

@felixge felixge closed this May 15, 2023
@mixn
Copy link
Owner

mixn commented May 15, 2023

Appreciate the quick and kind response, Felix. :) Thank you for your understanding and for closing the PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants