Yet another configurable shade callback #28
Conversation
|
Thank you for this! It will be a bit before I can test and review as I'm currently on holiday. I'll try to get around to it this weekend :) |
There was a problem hiding this comment.
I like this PR :) Its simple, the doc is clear and the logic is easy to follow.
I think we should make can_shade_callback use the provided example as its default (called out in a separate review) but otherwise this is good and I feel after that change, its ready for merge :)
README.md
Outdated
| -- lua | ||
| local sunglasses_options = { | ||
| can_shade_callback = function(opts) | ||
| local conditions = { |
There was a problem hiding this comment.
I like making this part of sunglasses_defaults
IE, by default users will have diffs "optionally" unshaded, though they can modify that logic if they choose. (by overriding this value in the provided default)
There was a problem hiding this comment.
That's a great idea!
Suggested changes are in 793b4b5.
Sorry if this is beating a dead horse, but I knew I was wanting similar functionality to what was suggested in #20, #22, and #27. I'm using this primarily to ignore diff files but wanted to make it relatively extensible.
Let me know what you think!