-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commercial fixes, CI tests, more tests, coverage #883
base: master
Are you sure you want to change the base?
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
I'm replacing email and password by env vars In the mean time, some tests related to commercial will fail on this PR |
a04d595
to
a95763d
Compare
a95763d
to
654ec42
Compare
DONE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But please address the check failure.
=================================== FAILURES ===================================
___________________________ test_commercial_commands ___________________________
WIP
Note: I think my auto-format is not well configured for .sh files, I'll fix to not overwrite lines I did not touch for nothing