Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select wilds datasets for NLP tools #155

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

Anmol-Srivastava
Copy link
Contributor

@Anmol-Srivastava Anmol-Srivastava commented Aug 7, 2023

Closes #151

Added

  • wilds install option
  • intermediate example notebook/converted script that downloads, demonstrates 2 wilds datasets

Changed

  • tweaked/removed outdated data generation scripts
  • tweaked .gitignore

@Anmol-Srivastava Anmol-Srivastava linked an issue Aug 7, 2023 that may be closed by this pull request
@Anmol-Srivastava
Copy link
Contributor Author

@tms-bananaquit all ready here, just a precursor to developing NLP detectors

Copy link
Collaborator

@tms-bananaquit tms-bananaquit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted these items in #154, for when the example is fleshed out:

  • Update README to note the wilds setup option
  • Update RTD/TOC to include example?

@tms-bananaquit
Copy link
Collaborator

The notebook currently downloads to data\amazon_v2.1\... if I run it from my default directory; the .gitignore targets /docs/source/examples/**/data. Maybe the notebook should be updated to point to that directory?

@Anmol-Srivastava
Copy link
Contributor Author

Updated README, the RTD perhaps we save for the example issue.

Clean fix to the download location seemed tricky, so I had the code download to "./wilds_datasets" and have the .gitignore ignore "wilds_datasets/" at any level

@Anmol-Srivastava Anmol-Srivastava merged commit 2ca8f03 into dev Aug 8, 2023
2 checks passed
@Anmol-Srivastava Anmol-Srivastava deleted the 151-wilds-datasets branch August 8, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select data for benchmarking
2 participants