Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regex matching for modules that should always fork #1255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nihlus
Copy link
Contributor

@Nihlus Nihlus commented Feb 28, 2025

The current logic used to match module names that should always fork has room for improvement. As exemplified by the recent addition of the FreeIPA modules, which was a rather long list, the ability to use patterns instead of exact string matches would improve readability and long-term maintainability of the mechanism.

This PR changes the module set into a set of regular expression strings and compiles them into a single joint regex that we then use to match against the module name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant