Fix bug in the benefit comparator

mitdbg · Nov 30, 2023 · 9484c07 · 9484c07
1 parent 1ced84a
commit 9484c07
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/brad/planner/compare/cost_with_benefit.py b/src/brad/planner/compare/cost_with_benefit.py
@@ -64,17 +64,19 @@ def is_better_than(left: ComparableBlueprint, right: ComparableBlueprint) -> boo
             penalty_multiplier,
         )
         right_score = _compute_scalar_score(
-            left.get_transition_time_s(),
-            left.get_transition_cost(),
+            right.get_transition_time_s(),
+            right.get_transition_cost(),
             curr_hourly_cost,
-            left.get_operational_monetary_cost(),
+            right.get_operational_monetary_cost(),
             benefit_horizon,
             penalty_multiplier,
         )
 
         # For debugging purposes.
         left.set_memoized_value("benefit_penalty_multiplier", penalty_multiplier)
         right.set_memoized_value("benefit_penalty_multiplier", penalty_multiplier)
+        left.set_memoized_value("cost_score", left_score)
+        right.set_memoized_value("cost_score", right_score)
 
         return left_score < right_score